Skip to content

fix(ide): use relative path for IDE icons - #452

Merged
skevetter merged 1 commit into
mainfrom
fix/ide-icons-loading
May 27, 2026
Merged

fix(ide): use relative path for IDE icons#452
skevetter merged 1 commit into
mainfrom
fix/ide-icons-loading

Conversation

@skevetter

@skevetter skevetter commented May 27, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Summary

  • PR feat(ide): add code-server as a browser-based IDE option #449 introduced IDE icons using absolute paths (/icons/ides/...), which resolve to filesystem root under Electron's file:// protocol and fail to load.
  • Switch to relative paths (./icons/ides/...) to match the existing ProviderIcon.svelte convention.

Summary by CodeRabbit

  • Bug Fixes
    • Fixed IDE icon display in the workspace wizard to ensure development environment icons load correctly.

Review Change Stack

@skevetter
fix(ide): use relative path for IDE icons so they load under file://
7806df8 
Absolute /icons/... paths resolve to filesystem root in packaged
Electron, so none of the IDE icons rendered. Match the existing
ProviderIcon convention with ./icons/... instead.
@netlify

netlify Bot commented May 27, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit 7806df8
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6a1781fd73390d0009f51f01

@coderabbitai

coderabbitai Bot commented May 27, 2026 •
edited
Loading

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c61d040e-f136-4f84-b53b-0b7422dcba6b

📥 Commits

Reviewing files that changed from the base of the PR and between 17f4a7c and 7806df8.

📒 Files selected for processing (1)
  • desktop/src/renderer/src/lib/components/workspace/WorkspaceWizard.svelte
📝 Walkthrough

Walkthrough

This PR updates the IDE icon URL generation in the WorkspaceWizard component, changing from root-relative paths to relative paths when constructing URLs for IDE icon SVGs.

Changes

Icon URL Path Format

Layer / File(s) Summary
Icon URL path generation
desktop/src/renderer/src/lib/components/workspace/WorkspaceWizard.svelte		 IDE icon helper function modified to generate relative paths (./icons/ides/${name}.svg) instead of root-relative paths (/icons/ides/${name}.svg) for icon image loading.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: switching IDE icon paths from absolute to relative format to fix loading issues in Electron.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint skipped: no ESLint configuration detected in root package.json. To enable, add eslint to devDependencies.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@skevetter
skevetter enabled auto-merge (squash) May 27, 2026 23:45
@skevetter
skevetter merged commit a864627 into main May 27, 2026
20 checks passed
@skevetter
skevetter deleted the fix/ide-icons-loading branch May 27, 2026 23:50
@coderabbitai coderabbitai Bot mentioned this pull request May 28, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size/xs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@skevetter